From d10f84750c10d933ef84aef393beaa736b8addb5 Mon Sep 17 00:00:00 2001
From: Tobias Zoghaib <tobias.zoghaib@stud.uni-hannover.de>
Date: Thu, 7 Nov 2024 19:18:50 +0100
Subject: [PATCH] Massive improvement of database creation time (63s -> 7s)

---
 .../backend/models/ordering/order.model.ts    |  5 ++
 software/backend/scripts/databaseHelper.ts    | 72 ++++++++++++-------
 .../src/data/models/ordering/orderModel.ts    |  5 +-
 3 files changed, 56 insertions(+), 26 deletions(-)

diff --git a/software/backend/models/ordering/order.model.ts b/software/backend/models/ordering/order.model.ts
index a536a72..846fe4e 100644
--- a/software/backend/models/ordering/order.model.ts
+++ b/software/backend/models/ordering/order.model.ts
@@ -24,6 +24,11 @@ export class Order extends Model {
   @Column
   paymentId: number
 
+  @Default(false)
+  @Column
+  shipped: boolean
+
+
 
   // Relations
 
diff --git a/software/backend/scripts/databaseHelper.ts b/software/backend/scripts/databaseHelper.ts
index 1fa8d13..e135c5c 100644
--- a/software/backend/scripts/databaseHelper.ts
+++ b/software/backend/scripts/databaseHelper.ts
@@ -25,6 +25,7 @@ import citiesLocations from "./../data/cities-locations.json"
 import exercises from "./../data/exercises.json"
 import bandsConcerts from "./../data/bands-concerts.json"
 import { Op } from 'sequelize'
+import moment from 'moment'
 
 
 /**
@@ -75,11 +76,16 @@ export async function prepopulateExerciseDatabase() {
  */
 export async function prepopulateDatabase() {
   deleteAllTables()
+
+  let start = moment()
   
 
 
   ////////// Locations and Seat Tables //////////
 
+  // Buffer seats, write them in one bulk action to the DB
+  let seats = []
+
   for (let city of citiesLocations.cities)
   {
     await City.create(city)
@@ -94,9 +100,9 @@ export async function prepopulateDatabase() {
           await Location.create(location)
             .then(async locationDataset => {
               let capacity = 0
+              let seatGroups = []
 
-              for (let seatGroup of location.seatGroups)
-              {
+              for (let seatGroup of location.seatGroups) {
                 seatGroup["locationId"] = locationDataset.id
 
                 let surcharge = 0
@@ -120,47 +126,59 @@ export async function prepopulateDatabase() {
                 }
 
                 seatGroup["surcharge"] = surcharge
-                
-                await SeatGroup.create(seatGroup)
-                  .then(async seatGroupRes => {
-                    if (seatGroup.standingArea) {
+
+                seatGroups.push(seatGroup)
+              }
+
+              await SeatGroup.bulkCreate(seatGroups)
+                .then(async seatGroupsRes => {
+                  for (let seatGroup of seatGroupsRes) {
+                    if (seatGroup.dataValues.standingArea) {
                       // In an area without seats, create one row with all "seats"
                       await SeatRow.create({
                         row: 0,
-                        seatGroupId: seatGroupRes.id
+                        seatGroupId: seatGroup.dataValues.id
                       })
                         .then(async seatRowRes => {
-                          for (let i = 0; i < seatGroup.capacity; i++) {
-                            await Seat.create({
+                          for (let i = 0; i < seatGroup.dataValues.capacity; i++) {
+                            seats.push({
                               seatNr: i + 1,
                               seatRowId: seatRowRes.id
                             })
 
                             capacity++
                           }
+
+                          await Seat.bulkCreate(seats)
                         })
                     }
                     else
                     {
-                      for (let row = 0; row < location.rows; row++) {
-                        await SeatRow.create({
-                          row: row + 1,
-                          seatGroupId: seatGroupRes.id
-                        })
-                          .then(async seatRowRes => {
-                            for (let col = 0; col < seatGroup.capacity / location.rows; col++) {
-                              await Seat.create({
-                                seatNr: col,
-                                seatRowId: seatRowRes.id
-                              })
+                      let seatRows = []
 
-                              capacity++
-                            }
-                          })
+                      for (let row = 0; row < location.rows; row++) {
+                        seatRows.push({
+                          row: row + 1,
+                          SeatGroupId: seatGroup.dataValues.id
+                        })
                       }
+
+                      await SeatRow.bulkCreate(seatRows)
+                        .then(seatRowRes => {
+                          for (let seatRow of seatRowRes) {
+                            for (let col = 0; col < seatGroup.capacity / location.rows; col++) {
+                              seats.push({
+                                  seatNr: col,
+                                  seatRowId: seatRow.id
+                                })
+
+                                capacity++
+                            }
+                          }
+                        })
                     }
-                  })
-              }
+                  }
+                })
 
             // Update capacity of location
             await Location.update(
@@ -176,6 +194,8 @@ export async function prepopulateDatabase() {
       })
   }
 
+  // Create seats to the database as bulk for better performance
+  await Seat.bulkCreate(seats)
 
 
   ////////// Account Tables //////////
@@ -355,4 +375,6 @@ export async function prepopulateDatabase() {
         }
       })
   }
+
+  console.log(moment().diff(start))
 }
\ No newline at end of file
diff --git a/software/src/data/models/ordering/orderModel.ts b/software/src/data/models/ordering/orderModel.ts
index 0799e82..d8f01a3 100644
--- a/software/src/data/models/ordering/orderModel.ts
+++ b/software/src/data/models/ordering/orderModel.ts
@@ -1,5 +1,8 @@
 export class OrderModel {
   id: number
-  shippingProgress: number
+  accountId: number
   orderedAt: string
+  addressId: number
+  paymentId: number
+  shipped: boolean
 }
\ No newline at end of file