Bugfix, Readme

README.md

@@ -7,7 +7,7 @@
 This extension switches the background image of your Cinnamon desktop multiple times in a day, based on a location or custom time periods. You can choose between included image-sets, your own HEIC-file or a source folder with single images. Configuration through a user-friendly configuration window.
 
 ### Features
-- 8 included image sets
+- 9 included image sets
 - 10 day periods
 - HEIF converter
 - Image configuration assistent with simple one-click setup for image choices
@@ -73,10 +73,10 @@ The image sets are from https://github.com/adi1090x/dynamic-wallpaper
 | ------ | ----- | ------ |
 | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/aurora/5.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/beach/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/bitday/4.jpg) |
 
-| Cliffs | Gradient | Lakeside | 
+| Cliffs | Earth | Gradient | 
 | -------- | --------- | ------ |
-| ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/cliffs/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/gradient/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/lakeside/4.jpg) |
+| ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/cliffs/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/earth/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/gradient/4.jpg) | 
 
-| Mountains | Sahara |
+| Lakeside | Mountains | Sahara |
-| --------- | ------ |
+| --------- | ------ | ------ |
-| ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/mountains/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/sahara/4.jpg) |
+| ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/lakeside/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/mountains/4.jpg) | ![](cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/sahara/4.jpg) |

cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/beach/9.jpg

@@ -0,0 +1 @@
+0.jpg

cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/cliffs/9.jpg

@@ -0,0 +1 @@
+0.jpg

cinnamon-dynamic-wallpaper@TobiZog/5.4/images/included_image_sets/mountains/9.jpg

@@ -0,0 +1 @@
+0.jpg

cinnamon-dynamic-wallpaper@TobiZog/5.4/loop.py

@@ -19,7 +19,7 @@ class Loop():
 
     # Position should estimate by network
     if self.prefs.period_source == PeriodSourceEnum.NETWORKLOCATION:
-      current_location = self.location.run()
+      current_location = self.location.get_location()
 
       self.suntimes.calc_suntimes(float(current_location["latitude"]), float(current_location["longitude"]))
       self.start_times = self.suntimes.day_periods
@@ -79,6 +79,7 @@ class Loop():
     """ Setting a gradient background to hide images, which are not high enough
     """
     # Load the image
+    try:
       im = Image.open(self.current_image_uri)
       pix = im.load()
 
@@ -98,6 +99,9 @@ class Loop():
       else:
         self.background_settings['primary-color'] = "#000000"
         self.background_settings['secondary-color'] = "#000000"
+    except:
+      self.background_settings['primary-color'] = "#000000"
+      self.background_settings['secondary-color'] = "#000000"
 
 
 # Needed for JavaScript

cinnamon-dynamic-wallpaper@TobiZog/5.4/preferences.glade

@@ -414,6 +414,12 @@
                         <property name="margin-end">12</property>
                         <property name="margin-top">12</property>
                         <property name="margin-bottom">12</property>
+                        <property name="orientation">vertical</property>
+                        <property name="homogeneous">True</property>
+                        <child>
+                          <object class="GtkBox">
+                            <property name="visible">True</property>
+                            <property name="can-focus">False</property>
                             <property name="homogeneous">True</property>
                             <child>
                               <object class="GtkLabel">
@@ -430,13 +436,35 @@
                               </packing>
                             </child>
                             <child>
-                          <object class="GtkFileChooserButton" id="fc_source_folder">
+                              <object class="GtkButton" id="btn_source_folder">
+                                <property name="label" translatable="yes">Open file selection dialog</property>
+                                <property name="visible">True</property>
+                                <property name="can-focus">True</property>
+                                <property name="receives-default">True</property>
+                                <signal name="clicked" handler="on_btn_source_folder_clicked" swapped="no"/>
+                              </object>
+                              <packing>
+                                <property name="expand">False</property>
+                                <property name="fill">True</property>
+                                <property name="position">1</property>
+                              </packing>
+                            </child>
+                          </object>
+                          <packing>
+                            <property name="expand">False</property>
+                            <property name="fill">True</property>
+                            <property name="position">0</property>
+                          </packing>
+                        </child>
+                        <child>
+                          <object class="GtkLabel" id="lbl_source_folder">
                             <property name="visible">True</property>
                             <property name="can-focus">False</property>
-                            <property name="action">select-folder</property>
+                            <property name="margin-top">16</property>
-                            <property name="title" translatable="yes"/>
+                            <property name="label" translatable="yes">label</property>
-                            <signal name="file-set" handler="on_fc_source_folder_file_set" swapped="no"/>
+                            <attributes>
-                            <signal name="selection-changed" handler="on_fc_source_folder_file_set" swapped="no"/>
+                              <attribute name="style" value="italic"/>
+                            </attributes>
                           </object>
                           <packing>
                             <property name="expand">False</property>
@@ -916,8 +944,8 @@
           <object class="GtkBox" id="gtkbox_location_time">
             <property name="visible">True</property>
             <property name="can-focus">False</property>
-            <property name="margin-start">24</property>
+            <property name="margin-start">16</property>
-            <property name="margin-end">24</property>
+            <property name="margin-end">16</property>
             <property name="margin-top">8</property>
             <property name="margin-bottom">8</property>
             <property name="orientation">vertical</property>
@@ -927,7 +955,6 @@
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
                 <property name="halign">start</property>
-                <property name="margin-start">64</property>
                 <property name="label" translatable="yes">Period estimation</property>
                 <attributes>
                   <attribute name="weight" value="bold"/>
@@ -1112,7 +1139,6 @@
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
                 <property name="halign">start</property>
-                <property name="margin-start">64</property>
                 <property name="label" translatable="yes">Location estimation</property>
                 <attributes>
                   <attribute name="weight" value="bold"/>
@@ -1128,8 +1154,6 @@
               <object class="GtkListBox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="margin-start">64</property>
-                <property name="margin-end">64</property>
                 <property name="selection-mode">none</property>
                 <property name="activate-on-single-click">False</property>
                 <child>
@@ -2408,8 +2432,8 @@
           <object class="GtkBox" id="gtkbox_behaviour">
             <property name="visible">True</property>
             <property name="can-focus">False</property>
-            <property name="margin-start">8</property>
+            <property name="margin-start">16</property>
-            <property name="margin-end">8</property>
+            <property name="margin-end">16</property>
             <property name="margin-top">8</property>
             <property name="margin-bottom">8</property>
             <property name="orientation">vertical</property>
@@ -2417,10 +2441,6 @@
               <object class="GtkListBox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="margin-left">64</property>
-                <property name="margin-right">64</property>
-                <property name="margin-start">64</property>
-                <property name="margin-end">64</property>
                 <property name="selection-mode">none</property>
                 <property name="activate-on-single-click">False</property>
                 <child>
@@ -2531,8 +2551,8 @@
           <object class="GtkBox" id="gtkbox_about">
             <property name="visible">True</property>
             <property name="can-focus">False</property>
-            <property name="margin-start">24</property>
+            <property name="margin-start">16</property>
-            <property name="margin-end">24</property>
+            <property name="margin-end">16</property>
             <property name="margin-top">8</property>
             <property name="margin-bottom">8</property>
             <property name="orientation">vertical</property>
@@ -2542,7 +2562,6 @@
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
                 <property name="halign">start</property>
-                <property name="margin-start">64</property>
                 <property name="label" translatable="yes">About the project</property>
                 <attributes>
                   <attribute name="weight" value="bold"/>
@@ -2558,8 +2577,6 @@
               <object class="GtkListBox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="margin-start">64</property>
-                <property name="margin-end">64</property>
                 <property name="selection-mode">none</property>
                 <property name="activate-on-single-click">False</property>
                 <child>
@@ -2646,7 +2663,6 @@
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
                 <property name="halign">start</property>
-                <property name="margin-start">64</property>
                 <property name="label" translatable="yes">Source Code</property>
                 <attributes>
                   <attribute name="weight" value="bold"/>
@@ -2662,8 +2678,6 @@
               <object class="GtkListBox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="margin-start">64</property>
-                <property name="margin-end">64</property>
                 <property name="selection-mode">none</property>
                 <property name="activate-on-single-click">False</property>
                 <child>
@@ -2714,7 +2728,6 @@
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
                 <property name="halign">start</property>
-                <property name="margin-start">64</property>
                 <property name="label" translatable="yes">Issues and Enhancements</property>
                 <attributes>
                   <attribute name="weight" value="bold"/>
@@ -2730,8 +2743,6 @@
               <object class="GtkListBox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="margin-start">64</property>
-                <property name="margin-end">64</property>
                 <property name="selection-mode">none</property>
                 <property name="activate-on-single-click">False</property>
                 <child>
@@ -2810,6 +2821,7 @@
             <property name="visible">True</property>
             <property name="can-focus">True</property>
             <property name="receives-default">True</property>
+            <property name="tooltip-text" translatable="yes">Apply and close this window</property>
             <property name="use-stock">True</property>
             <property name="always-show-image">True</property>
             <signal name="clicked" handler="on_ok" swapped="no"/>
@@ -2821,6 +2833,7 @@
             <property name="visible">True</property>
             <property name="can-focus">True</property>
             <property name="receives-default">True</property>
+            <property name="tooltip-text" translatable="yes">Apply the settings without closing this window</property>
             <property name="double-buffered">False</property>
             <property name="use-stock">True</property>
             <property name="always-show-image">True</property>

cinnamon-dynamic-wallpaper@TobiZog/5.4/preferences.py

@@ -8,6 +8,7 @@ from scripts.cinnamon_pref_handler import *
 from scripts.suntimes import *
 from scripts.location import *
 from scripts.images import *
+from scripts.dialogs import *
 from enums.ImageSourceEnum import ImageSourceEnum
 from enums.PeriodSourceEnum import PeriodSourceEnum
 from loop import *
@@ -32,10 +33,11 @@ class Preferences:
 	def __init__(self) -> None:
 		# Objects from external scripts
 		self.time_bar_chart = Time_Bar_Chart()
-		self.c_prefs = Cinnamon_Pref_Handler()
+		self.prefs = Cinnamon_Pref_Handler()
 		self.suntimes = Suntimes()
 		self.images = Images()
 		self.location = Location()
+		self.dialogs = Dialogs()
 
 		# Glade
 		self.builder = Gtk.Builder()
@@ -58,7 +60,8 @@ class Preferences:
 
 		# Source folder
 		self.lbr_source_folder: Gtk.ListBoxRow = self.builder.get_object("lbr_source_folder")
-		self.fc_source_folder: Gtk.FileChooser = self.builder.get_object("fc_source_folder")
+		self.btn_source_folder: Gtk.Button = self.builder.get_object("btn_source_folder")
+		self.lbl_source_folder: Gtk.Label = self.builder.get_object("lbl_source_folder")
 
 		# Time bar chart
 		self.img_bar_images: Gtk.Image = self.builder.get_object("img_bar_images")
@@ -144,30 +147,27 @@ class Preferences:
 		window = self.builder.get_object("window_main")
 		window.show_all()
 
-		# todo: Remove after HEIC implementation
-		self.tb_heic_file.set_visible(False)
-
 		# Load from preferences
-		if self.c_prefs.image_source == ImageSourceEnum.IMAGESET:
+		if self.prefs.image_source == ImageSourceEnum.IMAGESET:
 			self.tb_image_set.set_active(True)
-		elif self.c_prefs.image_source == ImageSourceEnum.HEICFILE:
+		elif self.prefs.image_source == ImageSourceEnum.HEICFILE:
 			self.tb_heic_file.set_active(True)
-		elif self.c_prefs.image_source == ImageSourceEnum.SOURCEFOLDER:
+		elif self.prefs.image_source == ImageSourceEnum.SOURCEFOLDER:
 			self.tb_source_folder.set_active(True)
 
 
-		picture_aspects = ["mosaic", "centered", "scaled", "stretched", "zoom", "spanned"]
+		picture_aspects = ["centered", "scaled", "stretched", "zoom", "spanned"]
 		self.add_items_to_combo_box(self.cb_picture_aspect, picture_aspects)
-		self.set_active_combobox_item(self.cb_picture_aspect, self.c_prefs.picture_aspect)
+		self.set_active_combobox_item(self.cb_picture_aspect, self.prefs.picture_aspect)
 
-		self.sw_dynamic_background_color.set_active(self.c_prefs.dynamic_background_color)
+		self.sw_dynamic_background_color.set_active(self.prefs.dynamic_background_color)
 
 
-		if self.c_prefs.period_source == PeriodSourceEnum.NETWORKLOCATION:
+		if self.prefs.period_source == PeriodSourceEnum.NETWORKLOCATION:
 			self.tb_network_location.set_active(True)
-		elif self.c_prefs.period_source == PeriodSourceEnum.CUSTOMLOCATION:
+		elif self.prefs.period_source == PeriodSourceEnum.CUSTOMLOCATION:
 			self.tb_custom_location.set_active(True)
-		elif self.c_prefs.period_source == PeriodSourceEnum.CUSTOMTIMEPERIODS:
+		elif self.prefs.period_source == PeriodSourceEnum.CUSTOMTIMEPERIODS:
 			self.tb_time_periods.set_active(True)
 
 
@@ -198,15 +198,14 @@ class Preferences:
 		# Stores the start times of the periods in minutes since midnight
 		time_periods_min = []
 
-		if self.c_prefs.period_source == PeriodSourceEnum.CUSTOMTIMEPERIODS:
+		if self.prefs.period_source == PeriodSourceEnum.CUSTOMTIMEPERIODS:
 			for i in range(0, 10):
-				time_str = self.c_prefs.period_custom_start_time[i]
+				time_str = self.prefs.period_custom_start_time[i]
 
 				time_periods_min.append(int(time_str[0:2]) * 60 + int(time_str[3:5]))
 		else:
-			if self.c_prefs.period_source == PeriodSourceEnum.NETWORKLOCATION:
+			if self.prefs.period_source == PeriodSourceEnum.NETWORKLOCATION:
-				self.suntimes.calc_suntimes(float(self.c_prefs.latitude_auto), 
+				self.suntimes.calc_suntimes(float(self.prefs.latitude_auto), float(self.prefs.longitude_auto))
-																float(self.c_prefs.longitude_auto))
 			else:
 				self.suntimes.calc_suntimes(float(self.etr_latitude.get_text()), float(self.etr_longitude.get_text()))	
 
@@ -221,7 +220,7 @@ class Preferences:
 					time_range_next = time(hour=23, minute=59)
 
 				self.etr_periods[i].set_text(
-					str(time_range_now.hour).rjust(2, '0') + ":" + str(time_range_now.minute).rjust(2, '0') +\
+					str(time_range_now.hour).rjust(2, '0') + ":" + str(time_range_now.minute).rjust(2, '0') + \
 						" - " + str(time_range_next.hour).rjust(2, '0') + ":" + str(time_range_next.minute).rjust(2, '0'))
 				
 				time_periods_min.append(time_range_now.hour * 60 + time_range_now.minute)
@@ -244,14 +243,22 @@ class Preferences:
 		Args:
 				options (list): All possible options
 		"""
+		options.insert(0, "")
+
 		for combobox in self.cb_periods:
 			self.add_items_to_combo_box(combobox, options)
 
 
-	def load_image_to_preview(self, image_preview: Gtk.Image, image_src: list):
+	def load_image_to_preview(self, image_preview: Gtk.Image, image_src: str):
+		""" Scales the image to a lower resoultion and put them into the time bar chart
+
+		Args:
+				image_preview (Gtk.Image): Gtk Image where it will be displayed
+				image_src (str): Absolute path to the image
+		"""
 		try:
 			pixbuf = GdkPixbuf.Pixbuf.new_from_file(image_src)
-			pixbuf = pixbuf.scale_simple(250, 175, GdkPixbuf.InterpType.BILINEAR)
+			pixbuf = pixbuf.scale_simple(260, 150, GdkPixbuf.InterpType.BILINEAR)
 
 			image_preview.set_from_pixbuf(pixbuf)
 		except:
@@ -309,9 +316,14 @@ class Preferences:
 	# | Image Set | HEIC file | Source Folder |
 	# +-----------+-----------+---------------+
 
-	def on_toggle_button_image_set_clicked(self, button: Gtk.Button):
+	def on_toggle_button_image_set_clicked(self, button: Gtk.ToggleButton):
+		""" Clicked on ToggleButton "Image Set"
+
+		Args:
+				button (Gtk.ToggleButton): Clicked ToggleButton
+		"""
 		if button.get_active():
-			self.c_prefs.image_source = ImageSourceEnum.IMAGESET
+			self.prefs.image_source = ImageSourceEnum.IMAGESET
 			self.tb_heic_file.set_active(False)
 			self.tb_source_folder.set_active(False)
 
@@ -319,13 +331,13 @@ class Preferences:
 			self.lbr_heic_file.set_visible(False)
 			self.lbr_source_folder.set_visible(False)
 
-			image_set_choices = ["aurora", "beach", "bitday", "cliffs", "gradient", "lakeside", "mountains", "sahara"]
+			image_set_choices = ["aurora", "beach", "bitday", "cliffs", "earth", "gradient", "lakeside", "mountains", "sahara"]
 			self.add_items_to_combo_box(self.cb_image_set, image_set_choices)
 
-			self.set_active_combobox_item(self.cb_image_set, self.c_prefs.selected_image_set)
+			self.set_active_combobox_item(self.cb_image_set, self.prefs.selected_image_set)
 
 			for i, combobox in enumerate(self.cb_periods):
-				selected_image_name = self.c_prefs.period_images[i]
+				selected_image_name = self.prefs.period_images[i]
 				self.set_active_combobox_item(combobox, selected_image_name)
 
 			# Make the comboboxes invisible
@@ -333,9 +345,14 @@ class Preferences:
 				combobox.set_visible(False)
 		
 	
-	def on_toggle_button_heic_file_clicked(self, button: Gtk.Button):
+	def on_toggle_button_heic_file_clicked(self, button: Gtk.ToggleButton):
+		""" Clicked on ToggleButton "Heic file"
+
+		Args:
+				button (Gtk.ToggleButton): Clicked ToggleButton
+		"""
 		if button.get_active():
-			self.c_prefs.image_source = ImageSourceEnum.HEICFILE
+			self.prefs.image_source = ImageSourceEnum.HEICFILE
 			self.tb_image_set.set_active(False)
 			self.tb_source_folder.set_active(False)
 
@@ -347,10 +364,27 @@ class Preferences:
 			for combobox in self.cb_periods:
 				combobox.set_visible(True)
 
+			# Load images from source folder
+			files = self.images.get_images_from_folder(self.prefs.source_folder)
 
-	def on_toggle_button_source_folder_clicked(self, button: Gtk.Button):
+			if len(files) != 0:
+				self.load_image_options_to_combo_boxes(files)
+
+				# Load the values for the images from the preferences
+				for i in range(0, 10):
+					self.set_active_combobox_item(self.cb_periods[i], self.prefs.period_images[i])
+			else:
+				print("No image files!")
+
+
+	def on_toggle_button_source_folder_clicked(self, button: Gtk.ToggleButton):
+		""" Clicked on ToggleButton "Source Folder"
+
+		Args:
+				button (Gtk.ToggleButton): Clicked ToggleButton
+		"""
 		if button.get_active():
-			self.c_prefs.image_source = ImageSourceEnum.SOURCEFOLDER
+			self.prefs.image_source = ImageSourceEnum.SOURCEFOLDER
 			self.tb_image_set.set_active(False)
 			self.tb_heic_file.set_active(False)
 
@@ -364,25 +398,46 @@ class Preferences:
 
 			# Load the source folder to the view
 			# This will update the comboboxes in the preview to contain the right items
-			self.fc_source_folder.set_filename(self.c_prefs.source_folder)
+			self.lbl_source_folder.set_label(self.prefs.source_folder)
+
+			# Load files from saved source folder
+			files = self.images.get_images_from_folder(self.prefs.source_folder)
+
+			if len(files) != 0:
+				self.load_image_options_to_combo_boxes(files)
+
+				# Load the values for the images from the preferences
+				for i in range(0, 10):
+					self.set_active_combobox_item(self.cb_periods[i], self.prefs.period_images[i])
+			else:
+				print("No image files!")
 
 
 
+	# +------------------------------------+
+	# | Select an image set     | aurora ▼ |
+	# +------------------------------------+
+
 	def on_cb_image_set_changed(self, combobox: Gtk.ComboBox):
+		""" User select on of the included image sets
+
+		Args:
+				combobox (Gtk.ComboBox): The used ComboBox
+		"""
 		tree_iter = combobox.get_active_iter()
 
-		if tree_iter is not None and self.c_prefs.image_source == ImageSourceEnum.IMAGESET:
+		if tree_iter is not None and self.prefs.image_source == ImageSourceEnum.IMAGESET:
 			# Get the selected value
 			model = combobox.get_model()
 			selected_image_set = model[tree_iter][0]
 
 			# Store to the preferences
-			self.c_prefs.selected_image_set = selected_image_set
+			self.prefs.selected_image_set = selected_image_set
-			self.c_prefs.source_folder = os.path.abspath(os.path.join(PREFERENCES_URI, os.pardir)) + \
+			self.prefs.source_folder = os.path.abspath(os.path.join(PREFERENCES_URI, os.pardir)) + \
 				  "/5.4/images/included_image_sets/" + selected_image_set + "/"
 			
 			# Load all possible options to the comboboxes
-			image_names = self.images.get_images_from_folder(self.c_prefs.source_folder)
+			image_names = self.images.get_images_from_folder(self.prefs.source_folder)
 			self.load_image_options_to_combo_boxes(image_names)
 
 			# Image sets have the same names for the images:
@@ -390,59 +445,78 @@ class Preferences:
 			# 1.jpg = Period 1
 			# 2.jpg = Period 2
 			# and so on....
-			self.cb_periods[0].set_active(8)
+			for i in range(0, 10):
-			for i in range(1, 10):
+				self.cb_periods[i].set_active(i + 1)
-				self.cb_periods[i].set_active(i - 1)
 
 
+	# +----------------------------------------------+
+	# | Select a heic file to import     | (None) 📄 |
+	# +----------------------------------------------+
+
 	def on_fc_heic_file_file_set(self, fc_button: Gtk.FileChooser):
-		file_path = fc_button.get_filename()
+		""" User has a heic file selected with the FileChooserDialog
-		extract_folder = os.path.abspath(os.path.join(PREFERENCES_URI, os.pardir)) + \
-				  "/images/extracted_images/"
 
-		file_name = file_path[file_path.rfind("/") + 1:]
+		Args:
-		file_name = file_name[:file_name.rfind(".")]
+				fc_button (Gtk.FileChooser): Parameter about the selected file
+		"""
+		# The the absolute path to the heic file
+		file_path: str = fc_button.get_filename()
+
+		# Extract the heic file
+		result = self.images.extract_heic_file(file_path)
 
 		# Update the preferences
-		self.c_prefs.selected_image_set = ""
+		self.prefs.selected_image_set = ""
-		self.c_prefs.source_folder = extract_folder
+		self.prefs.source_folder = PREFERENCES_URI + "/images/extracted_images/"
-
-		# Create the buffer folder
-		try:
-			os.mkdir(extract_folder)
-		except:
-			pass
-
-		# Extract the HEIC file
-		for file in self.images.get_images_from_folder(extract_folder):
-			os.remove(extract_folder + file)
-
-		os.system("heif-convert " + file_path + " " + extract_folder + file_name + ".jpg")
 
+		# Load images only if the extraction was successfully
+		if result:
 			# Collect all extracted images and push them to the comboboxes
-		image_names = self.images.get_images_from_folder(self.c_prefs.source_folder)
+			image_names = self.images.get_images_from_folder(self.prefs.source_folder)
 			self.load_image_options_to_combo_boxes(image_names)
+		else:
+			self.dialogs.message_dialog("Error during extraction")
 
 
+	# +------------------------------------------------------------+
+	# | Select a source folder     | 📂 Open file selection dialog |
+	# |             /home/developer/Downloads/
+	# +------------------------------------------------------------+
 
-	def on_fc_source_folder_file_set(self, fc_button: Gtk.FileChooser):
+	def on_btn_source_folder_clicked(self, button: Gtk.Button):
-		files = self.images.get_images_from_folder(fc_button.get_filename())
+		""" Button to choose an image source folder was clicked
+
+		Args:
+				button (Gtk.Button): The clicked button
+		"""
+		folder = self.dialogs.source_folder_dialog()
+		files = self.images.get_images_from_folder(folder)
 
 		# Update the preferences
-		self.c_prefs.selected_image_set = ""
+		self.prefs.selected_image_set = ""
-		self.c_prefs.source_folder = fc_button.get_filename() + "/"
+		self.prefs.source_folder = folder + "/"
 
-		if len(files) != 0:
+		# Update the label
+		self.lbl_source_folder.set_label(folder)
+
+		# Update the image comboboxes
 		self.load_image_options_to_combo_boxes(files)
 
 		# Load the values for the images from the preferences
 		for i in range(0, 10):
-				self.set_active_combobox_item(self.cb_periods[i], self.c_prefs.period_images[i])
+			self.cb_periods[i].set_active(0)
-		else:
+			#self.set_active_combobox_item(self.cb_periods[i], "") #self.prefs.period_images[i])
-			pass
+
+		if len(files) == 1:
+			self.dialogs.message_dialog("No image files found!")
 	
 
 	def on_cb_period_preview_changed(self, combobox: Gtk.ComboBox):
+		""" User select an image from the ComboBox for the time period
+
+		Args:
+				combobox (Gtk.ComboBox): The used ComboBox
+		"""
 		tree_iter = combobox.get_active_iter()
 
 		combobox_name = Gtk.Buildable.get_name(combobox)
@@ -454,10 +528,10 @@ class Preferences:
 			image_file_name = model[tree_iter][0]
 
 			# Store selection to preferences
-			self.c_prefs.period_images[period_index] = image_file_name
+			self.prefs.period_images[period_index] = image_file_name
 
 			# Build up image path
-			image_path = self.c_prefs.source_folder + image_file_name
+			image_path = self.prefs.source_folder + image_file_name
 
 			self.load_image_to_preview(self.img_periods[period_index], image_path)
 	
@@ -466,7 +540,7 @@ class Preferences:
 
 	def on_toggle_button_network_location_clicked(self, button: Gtk.Button):
 		if button.get_active():
-			self.c_prefs.period_source = PeriodSourceEnum.NETWORKLOCATION
+			self.prefs.period_source = PeriodSourceEnum.NETWORKLOCATION
 			self.tb_custom_location.set_active(False)
 			self.tb_time_periods.set_active(False)
 
@@ -476,24 +550,24 @@ class Preferences:
 			self.lbr_custom_location_latitude.set_visible(False)
 			self.lbr_time_periods.set_visible(False)
 
-			self.spb_network_location_refresh_time.set_value(self.c_prefs.location_refresh_intervals)
+			self.spb_network_location_refresh_time.set_value(self.prefs.location_refresh_intervals)
 		
 
 			# Display the location in the UI
-			current_location = self.location.run()
+			current_location = self.location.get_location()
 			self.lb_current_location.set_text("Latitude: " + current_location["latitude"] + \
 																		 ", Longitude: " + current_location["longitude"])
 			
 			# Store the location to the preferences
-			self.c_prefs.latitude_auto = float(current_location["latitude"])
+			self.prefs.latitude_auto = float(current_location["latitude"])
-			self.c_prefs.longitude_auto = float(current_location["longitude"])
+			self.prefs.longitude_auto = float(current_location["longitude"])
 
 			self.refresh_chart()
 
 
 	def on_toggle_button_custom_location_clicked(self, button: Gtk.Button):
 		if button.get_active():
-			self.c_prefs.period_source = PeriodSourceEnum.CUSTOMLOCATION
+			self.prefs.period_source = PeriodSourceEnum.CUSTOMLOCATION
 			self.tb_network_location.set_active(False)
 			self.tb_time_periods.set_active(False)
 
@@ -503,13 +577,13 @@ class Preferences:
 			self.lbr_custom_location_latitude.set_visible(True)
 			self.lbr_time_periods.set_visible(False)
 
-			self.etr_latitude.set_text(str(self.c_prefs.latitude_custom))
+			self.etr_latitude.set_text(str(self.prefs.latitude_custom))
-			self.etr_longitude.set_text(str(self.c_prefs.longitude_custom))
+			self.etr_longitude.set_text(str(self.prefs.longitude_custom))
 
 
 	def on_toggle_button_time_periods_clicked(self, button: Gtk.Button):
 		if button.get_active():
-			self.c_prefs.period_source = PeriodSourceEnum.CUSTOMTIMEPERIODS
+			self.prefs.period_source = PeriodSourceEnum.CUSTOMTIMEPERIODS
 			self.tb_network_location.set_active(False)
 			self.tb_custom_location.set_active(False)
 
@@ -521,7 +595,7 @@ class Preferences:
 			
 			
 			for i in range(0, 9):
-				pref_value = self.c_prefs.period_custom_start_time[i + 1]
+				pref_value = self.prefs.period_custom_start_time[i + 1]
 				time_parts = [int(pref_value[0:pref_value.find(":")]), int(pref_value[pref_value.find(":") + 1:])]
 
 				self.spb_periods_hour[i].set_value(time_parts[0])
@@ -548,7 +622,7 @@ class Preferences:
 		time_current_start = datetime(2024,1,1, int(self.spb_periods_hour[index].get_value()), int(self.spb_periods_minute[index].get_value()))
 		time_current_start_str = str(time_current_start.hour).rjust(2, '0') + ":" + str(time_current_start.minute).rjust(2, '0')
 
-		self.c_prefs.period_custom_start_time[index + 1] = time_current_start_str
+		self.prefs.period_custom_start_time[index + 1] = time_current_start_str
 		
 
 		time_previous_end = time_current_start - timedelta(minutes=1)
@@ -558,13 +632,18 @@ class Preferences:
 		self.refresh_chart()
 
 
-	def on_spb_network_location_refresh_time_changed(self, spin_button):
+	def on_spb_network_location_refresh_time_changed(self, spin_button: Gtk.SpinButton):
-		self.c_prefs.location_refresh_intervals = spin_button.get_value()
+		""" User changed the refresh time of network location estimation
+
+		Args:
+				spin_button (Gtk.SpinButton): The used SpinButton
+		"""
+		self.prefs.location_refresh_intervals = spin_button.get_value()
 
 
 	def on_etr_longitude_changed(self, entry):
 		try:
-			self.c_prefs.longitude_custom = float(entry.get_text())
+			self.prefs.longitude_custom = float(entry.get_text())
 			self.refresh_chart()
 		except:
 			pass
@@ -572,7 +651,7 @@ class Preferences:
 
 	def on_etr_latitude_changed(self, entry):
 		try:
-			self.c_prefs.latitude_custom = float(entry.get_text())
+			self.prefs.latitude_custom = float(entry.get_text())
 			self.refresh_chart()
 		except:
 			pass
@@ -585,10 +664,10 @@ class Preferences:
 
 		if tree_iter is not None:
 			model = combobox.get_model()
-			self.c_prefs.picture_aspect = model[tree_iter][0]
+			self.prefs.picture_aspect = model[tree_iter][0]
 		
 	def on_sw_dynamic_background_color_state_set(self, switch: Gtk.Switch, state):
-		self.c_prefs.dynamic_background_color = state
+		self.prefs.dynamic_background_color = state
 
 
 	# About
@@ -633,7 +712,7 @@ class Preferences:
 		""" Callback for the Apply button in the top bar
 		"""
 		# Store all values to the JSON file
-		self.c_prefs.store_preferences()
+		self.prefs.store_preferences()
 
 		# Use the new settings
 		loop = Loop()

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/cinnamon_pref_handler.py

@@ -1,6 +1,8 @@
 import os, json
 
 class Cinnamon_Pref_Handler:
+  """ Class to work with the Cinnamon Extension preference format
+  """
   def __init__(self) -> None:
     # Location of the Cinnamon preference file since Cinnamon 5.4
     self.pref_location = os.path.expanduser("~") + \
@@ -54,6 +56,7 @@ class Cinnamon_Pref_Handler:
       pref_data['period_9_custom_start_time']['value']
   ]
 
+
   def store_preferences(self):
     """ Store the values of the Preference object to the JSON file
     """

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/dialogs.py

@@ -0,0 +1,61 @@
+import gi
+
+gi.require_version("Gtk", "3.0")
+from gi.repository import Gtk
+
+class Dialogs(Gtk.Window):
+  """ All used Gtk dialogs
+
+  Args:
+      Gtk (Gtk.Window): Window of Gtk application
+  """
+  def __init__(self) -> None:
+    super().__init__()
+
+
+  def source_folder_dialog(self) -> str:
+    """ Display a FileChooser dialog where the user choose a folder
+
+    Returns:
+        str: Absolute path to the selected folder
+    """
+    dialog = Gtk.FileChooserDialog(
+      title= "Please choose a folder with images",
+      parent=self,
+      action=Gtk.FileChooserAction.SELECT_FOLDER
+    )
+
+    dialog.add_buttons(
+      Gtk.STOCK_CANCEL, Gtk.ResponseType.CANCEL, "Select", Gtk.ResponseType.OK
+    )
+
+    dialog.set_default_size(800, 400)
+
+    response = dialog.run()
+
+    if response == Gtk.ResponseType.OK:
+      location = dialog.get_filename()
+    elif response == Gtk.ResponseType.CANCEL:
+      location = ""
+
+    dialog.destroy()
+
+    return location
+  
+  
+  def message_dialog(self, message: str):
+    """ Displaying a Gtk Message dialog to the user
+
+    Args:
+        message (str): Message which appear in the dialog
+    """
+    dialog = Gtk.MessageDialog(
+      transient_for=self,
+      flags=0,
+      message_type=Gtk.MessageType.INFO,
+      buttons=Gtk.ButtonsType.OK,
+      text=message
+    )
+
+    dialog.run()
+    dialog.destroy()

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/images.py

@@ -1,10 +1,60 @@
 import os
 
 class Images:
+	""" Class for image operations
+	"""
 	def __init__(self) -> None:
 		pass
 
+
 	def get_images_from_folder(self, URI: str) -> list:
-		items = os.listdir(URI)
+		""" List all images in a folder
+
+		Args:
+				URI (str): Absolute path of the folder
+
+		Returns:
+				list: List of file names which are images
+		"""
+		items = []
+
+		for file in os.listdir(URI):
+			if file.endswith(("jpg", "jpeg", "png", "bmp", "svg")):
+				items.append(file)
+
 		items.sort()
 		return items
+	
+
+	def extract_heic_file(self, file_uri: str) -> bool:
+		""" Extract a heic file to an internal folder
+
+		Args:
+				file_uri (str): Absolute path to the heic file
+
+		Returns:
+				bool: Extraction was successful
+		"""
+		try:
+			extract_folder = os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), os.pardir)) + \
+				"/images/extracted_images/"
+
+			file_name: str = file_uri[file_uri.rfind("/") + 1:]
+			file_name = file_name[:file_name.rfind(".")]
+
+			# Create the buffer folder if its not existing
+			try:
+				os.mkdir(extract_folder)
+			except:
+				pass
+
+			# Cleanup the folder
+			for file in self.get_images_from_folder(extract_folder):
+				os.remove(extract_folder + file)
+
+			# Extract the HEIC file
+			os.system("heif-convert '" + file_uri + "' '" + extract_folder + file_name + ".jpg'")
+
+			return True
+		except:
+			return False

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/location.py

@@ -1,10 +1,17 @@
 import urllib.request, json
 
 class Location():
+  """ Class to handle location requests
+  """
   def __init__(self):
     self.GEO_URL = "https://get.geojs.io/v1/ip/geo.json"
 
-  def run(self) -> dict:
+  def get_location(self) -> dict:
+    """ Request the location via network
+
+    Returns:
+        dict: latitude and longitude
+    """
     request = urllib.request.urlopen(self.GEO_URL)
 
     data = json.load(request)

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/suntimes.py

@@ -19,6 +19,12 @@ class Suntimes:
 
 
   def calc_suntimes(self, latitude: float, longitude: float) -> None:
+    """ Start the calculation process
+
+    Args:
+        latitude (float): Current latitude
+        longitude (float): Current longitude
+    """
     self.latitude = latitude
     self.longitude = longitude
     self.calc_sun_events()
@@ -43,6 +49,8 @@ class Suntimes:
 
 
   def calc_sun_events(self):
+    """ Parent sun event calculater. Calls calc_sunrise_sunset_time() for every time period
+    """
     civial_dawn_start = self.calc_sunrise_sunset_time(True, 96)
     sunrise_start = self.calc_sunrise_sunset_time(True)
     morning_start = self.calc_sunrise_sunset_time(True, 89.167)
@@ -71,8 +79,6 @@ class Suntimes:
     ]
 
 
-
-
   def calc_sunrise_sunset_time(self, is_sunrise: bool, zenith=90.833) -> datetime:
     """ Calculate all values to estimate the day periods
     """

cinnamon-dynamic-wallpaper@TobiZog/5.4/scripts/time_bar_chart.py

@@ -1,6 +1,8 @@
 import math
 
 class Time_Bar_Chart:
+  """ Class to handle the creation of the day time period bar
+  """
   def __init__(self) -> None:
     self.image_code = []
 
@@ -8,9 +10,9 @@ class Time_Bar_Chart:
         "00193d", 
         "05597f", 
         "54babf", 
-        "bfe3c2", 
+        "9ec3a1", 
-        "ffbf6b", 
+        "ffb95e", 
-        "fdb55c", 
+        "fcae4e", 
         "f37f73", 
         "b45bbc", 
         "7e38ce", 
@@ -21,9 +23,10 @@ class Time_Bar_Chart:
 
 
   def create_bar_chart_with_polylines(self, save_location: str, image_width: int, image_height: int, times: list):
-    """ Create a time bar chart
+    """ Create a time bar chart WITH polylines
 
     Args:
+        save_location (str): Absolute path to store
         image_width (int): Width of the image in pixel
         image_height (int): Height of the image in pixel
         times (list): List of start times of the periods in minutes since midnight
@@ -45,6 +48,14 @@ class Time_Bar_Chart:
 
 
   def create_bar_chart(self, save_location: str, image_width: int, image_height: int, times: list):
+    """ Create a time bar chart WITHOUT polylines
+
+    Args:
+        save_location (str): Absolute path to store
+        image_width (int): Width of the image in pixel
+        image_height (int): Height of the image in pixel
+        times (list): List of start times of the periods in minutes since midnight
+    """
     self.create_bar(image_width, image_height, times)
     self.create_time_markers(image_width, image_height)
 
@@ -96,13 +107,22 @@ class Time_Bar_Chart:
         image_height (int): Total height of the image
     """
     for i in range(0, 8):
+      # 3 hour vertical line
       self.image_code.append(
-        '<line x1="%s" y1="40" x2="%s" y2="%s" stroke="gray" stroke-width="2" />' %
+        '<line x1="%s" y1="40" x2="%s" y2="%s" stroke="white" stroke-width="2" />' %
           (i * (image_width // 8), i * (image_width // 8), image_height - 40)
       )
 
+      # The two hours between the 3 hour lines
+      for j in range(1, 3):
         self.image_code.append(
-        '<text x="%s" y="%s" fill="gray" font-size="20" font-family="Liberation Sans">%s</text>' %
+          '<line x1="%s" y1="40" x2="%s" y2="%s" stroke="white" stroke-width="0.5" />' %
+            (i * (image_width // 8) + image_width // 24 * j, i * (image_width // 8) + image_width // 24 * j, image_height - 40)
+        )
+      
+      # Time labels
+      self.image_code.append(
+        '<text x="%s" y="%s" fill="white" font-size="20" font-family="Liberation Sans">%s</text>' %
           (i * (image_width // 8) + 5, image_height - 45, i * 3)
       )